Client Encryption: Add client encryption / decryption for transactional batch requests #1331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j82w
reviewed
Apr 1, 2020
abhijitpai
reviewed
Apr 2, 2020
Microsoft.Azure.Cosmos/src/Batch/TransactionalBatchItemRequestOptions.cs
Outdated
Show resolved
Hide resolved
abhijitpai
reviewed
Apr 2, 2020
abhijitpai
previously approved these changes
Apr 2, 2020
j82w
reviewed
Apr 3, 2020
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/Batch/BatchAsyncBatcherTests.cs
Outdated
Show resolved
Hide resolved
j82w
previously approved these changes
Apr 3, 2020
Microsoft.Azure.Cosmos/src/Batch/BatchAsyncContainerExecutor.cs
Outdated
Show resolved
Hide resolved
j82w
changed the title
ealsur
reviewed
Apr 3, 2020
Microsoft.Azure.Cosmos/src/Batch/TransactionalBatchItemRequestOptions.cs
Outdated
Show resolved
Hide resolved
ealsur
previously approved these changes
Apr 6, 2020
Encryption and materialization might not be always together. Materialziation can be used on response paths also. Refers to: Microsoft.Azure.Cosmos/src/Batch/ItemBatchOperation.cs:319 in a607239. [](commit_id = a607239, deletion_comment = False) |
kirankumarkolli
previously approved these changes
Apr 6, 2020
kirankumarkolli
approved these changes
Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Enable client encryption / decryption for transactional batch requests.
Type of change
Closing issues
Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).
Assignee
anujtoshniwal
Projects
Please add relevant projects so this issue can be properly tracked.